Development experience #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
reviewed
Aug 6, 2018
README.md
Outdated
|
|
||
| Install the dependencies: | ||
|
|
||
| npm install |
There was a problem hiding this comment.
I think that for this code to render well, you have to enclose these shell script lines in triple-backtick code blocks.
There was a problem hiding this comment.
Thanks. Should be fixed now. https://github.com/skovhus/tree-sitter-bash/blob/70269801aed494decba0e5e7cafabdccb50cd24c/README.md
skovhus
force-pushed
the
development-support
branch
from
a856131
to
7026980
Compare
3 tasks
This was referenced Mar 3, 2020
Closed
skovhus
added a commit
to skovhus/tree-sitter-bash
that referenced
this pull request
Mar 4, 2020
* Rename prebuild target clashing with build target * Add test:watch target and documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the development experience by:
test:watchtarget which rebuilds and tests after making a change in the source files, corpus or examples (nice for TDD)prebuildtarget topre-buildso runningnpm run buildis much faster**) #20 introduced a
prebuildtarget, that has the consequence that local build and test cycle is really slow. The reason is that we are using the nameprebuildfor the target, which is always run before thebuildtarget.