fix: possible rollover of nanoseconds in clock.h #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, and thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a timeout on a parser can result in a non-deterministic behavior, where parsers time out when they should not. An incorrect timeout is more likely for timeout intervals closer to (but less than) 1s. We noticed that the distribution of these incorrect timeouts didn't seem to be correlated with the complexity of the inputs.
The cause seems to be this possible rollover of the nanoseconds component of
timespecinclock.h. Patching this fixes the timeout issue.I'm not sure how I would go about adding tests for this, but if you think they are necessary and can provide some pointers, I'd be happy to include them.
Thanks!