Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in ambiguity management #30

Merged
merged 7 commits into from
Feb 24, 2016
Merged

Fix bugs in ambiguity management #30

merged 7 commits into from
Feb 24, 2016

Conversation

maxbrunsfeld
Copy link
Contributor

Fixes an issue discovered in tree-sitter/tree-sitter-ruby#16

Debugging

This adds a ts_document_print_debugging_graphs function. When this boolean flag is set on the document, it dumps a DOT representation of the graph-structured parse stack after every parse action. This output can be piped directly to dot to produce a sequence of graphs and parse actions, like this:

screen shot 2016-02-23 at 5 41 04 pm

#### Bug fix

This fixes a bug wherein ambiguities were merged incorrectly, producing nonsensical parse trees.

maxbrunsfeld pushed a commit that referenced this pull request Feb 24, 2016
Fix bugs in ambiguity management
@maxbrunsfeld maxbrunsfeld merged commit 597e4b2 into master Feb 24, 2016
@maxbrunsfeld maxbrunsfeld deleted the debuggable-stack branch February 24, 2016 01:43
@robrix
Copy link
Member

robrix commented Feb 24, 2016

🤘 that’s pretty fantastic work dude!

BekaValentine pushed a commit that referenced this pull request Feb 23, 2021
Restructure some rules to allow typescript to extend this grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants