New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bindings)!: convert node bindings to NAPI #3077
Conversation
Rust and Python will also have breaking changes soon, so it's fine to break Node as well. One question: how would |
Just |
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
Co-authored-by: ObserverOfTime <chronobserver@disroot.org>
thanks @segevfiner, I'll try and help out/review the PR in node-ts as well |
Just note that as it stands this will only work with node-tree-sitter with that PR merged as there is no backwards or forwards compatibility in place. So be sure to merge it before releasing this. |
Yeah I know, we're not gonna have a release until then |
I did add forwards compatibility. The CLI will replace the old bindings with the new ones. |
I mean for importing the grammars in the node bindings. The non-napi node bindings can't import napi grammars and vice versa. |
This is a breaking change that accompanys tree-sitter/node-tree-sitter#190 and should only be merged along with it, with a proper strategy for how to update languages.
We need to consider how we are going to release such a thing as language authors will have to know to regenarate or modify those files...