Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bindings)!: convert node bindings to NAPI #3077

Merged
merged 7 commits into from
Feb 27, 2024
Merged

refactor(bindings)!: convert node bindings to NAPI #3077

merged 7 commits into from
Feb 27, 2024

Commits on Feb 25, 2024

  1. Convert language bindings to NAPI

    @segevfiner
    segevfiner committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    f304c01 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Fix review comment

    @segevfiner
    segevfiner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    38c8f94 View commit details
    Browse the repository at this point in the history

  2. Update binding.cc

    @segevfiner
    segevfiner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1d04348 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
    @segevfiner @verhovsky
    segevfiner and verhovsky committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fa590be View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into napi-2

    @segevfiner
    segevfiner committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f03a275 View commit details
    Browse the repository at this point in the history

  5. Update cli/src/generate/templates/js-binding.cc 

    Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
    @segevfiner @verhovsky
    segevfiner and verhovsky committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f11ee64 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. fixup!: replace existing node bindings 

    Co-authored-by: ObserverOfTime <chronobserver@disroot.org>
    @amaanq @ObserverOfTime
    amaanq and ObserverOfTime committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    21f7894 View commit details
    Browse the repository at this point in the history