test: don't use TS_REUSE_ALLOCATOR on Darwin systems #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
force-pushed
the
macos-link-test
branch
from
98a6278
to
ea77657
Compare
For some reason, the linker seems to behave a bit differently with `-exported_symbols_list` on macOS vs other operating systems, so we'll disable this for now
amaanq
force-pushed
the
macos-link-test
branch
from
ea77657
to
21d828c
Compare
amaanq
changed the title
| @@ -30,9 +30,6 @@ fn main() { | |||
| target_os = "dragonfly", | |||
| ))] | |||
| println!("cargo:rustc-link-arg=-Wl,--dynamic-list=cli/dynamic-symbols.txt"); | |||
|
|
|||
| #[cfg(any(target_os = "macos", target_os = "ios"))] | |||
| println!("cargo:rustc-link-arg=-Wl,-exported_symbols_list,cli/dynamic-symbols-darwin.txt"); | |||
There was a problem hiding this comment.
do we still need the dynamic-symbols-darwin.txt file?
There was a problem hiding this comment.
not currently, but I sort of wanted to take a deeper dive and figure out why it doesn't work only for macOS, and see if I can fix it probably tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the linker seems to behave a bit differently with
-exported_symbols_liston macOS only for tests vs other operating systems, so we'll disable this for now