Lower the lib's MSRV #3169
Merged
Lower the lib's MSRV #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @the-mikedavis. This totally makes sense. I wish we could lower it for the whole workspace, but we currently cannot because of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally libraries should specify their MSRV as the minimum that is required to build. Keeping the MSRV below 1.70 is crucial for us as we follow Firefox's MSRV policy. Like @Wilfred mentioned in #2669, some distros lag with their Rust versions and keeping a low MSRV is the only way we can be packaged in those distros.
I've only made this change for the lib since that's the important part for downstream consumers.