Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] copy tile-present/version files to map archive #51

Conversation

mweirauch
Copy link
Contributor

This PR…

adds the - currently static numbered - tile-present/version files to the map archival commands.

@treee111
Copy link
Owner

treee111 commented Oct 21, 2021

Hi!
this looks like an enhancement of #49?
I don't really know for what the .12 files are used. Is it for the newer models ROAM and BOLTv2?

PS: I pushed a commit to delete the (debugging) output. :-)

@mweirauch
Copy link
Contributor Author

mweirauch commented Oct 21, 2021

Yes, they are used by the BoltApp to check map and routing tile presence. If they are not there it will fail map and routing data validation triggered by the Companion app. At least if they are missing for the routing files, routing is not possible. I think map loading on the device was still fine if the version file was not present. (But my memory is lost on that one.)

In any case, one wants to have these files on both (map and routing tiles), so that the tile checks triggered in the Companion app tell you that everything is alright.

PS: I am gonna force-push again withouth the cmd. Sorry, wasn't paying attention.
PPS: observations on BoltV2 and Companion app

@mweirauch mweirauch force-pushed the copy-version-files-to-map-archive branch from 5184dcc to b34adf7 Compare October 21, 2021 21:19
@mweirauch mweirauch force-pushed the copy-version-files-to-map-archive branch from b34adf7 to 0936288 Compare October 21, 2021 21:23
@mweirauch
Copy link
Contributor Author

This seems to be superseeded by #47 from the looks of it. So perhaps just wait for that one and drop this one here then.

@treee111
Copy link
Owner

Sounds good and useful to copy them also in the archive!

You are right, the other PR carries out zipping-changes.
But I think keeping this separate because it is a separate function makes sense, too.

If that is OK for you? You might rebase another time, I'm sorry ;-)

@mweirauch
Copy link
Contributor Author

What I wanted to say is, the other work from Ebe already contains the same functionality if I am not completely mistaken. I'll check when I am back from holidays and report back.

@treee111
Copy link
Owner

Sure, no hurry in here! :)

Concerning the .lzma.12 files I don't something in #47.
In my opinion #46 creates the .lzma.12 files and this #51 copies them to the archive.
In my head that makes sense but 100% possible that I am mistaken and missed something ;-)

@treee111
Copy link
Owner

You are right, the copy of the files is already included in #47. I totally missed that...

Closing this PR.

@treee111 treee111 closed this Oct 22, 2021
@mweirauch mweirauch deleted the copy-version-files-to-map-archive branch October 27, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants