-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] copy tile-present/version files to map archive #51
[FIX] copy tile-present/version files to map archive #51
Conversation
Hi! PS: I pushed a commit to delete the (debugging) output. :-) |
Yes, they are used by the BoltApp to check map and routing tile presence. If they are not there it will fail map and routing data validation triggered by the Companion app. At least if they are missing for the routing files, routing is not possible. I think map loading on the device was still fine if the version file was not present. (But my memory is lost on that one.) In any case, one wants to have these files on both (map and routing tiles), so that the tile checks triggered in the Companion app tell you that everything is alright. PS: I am gonna force-push again withouth the cmd. Sorry, wasn't paying attention. |
5184dcc
to
b34adf7
Compare
b34adf7
to
0936288
Compare
This seems to be superseeded by #47 from the looks of it. So perhaps just wait for that one and drop this one here then. |
Sounds good and useful to copy them also in the archive! You are right, the other PR carries out zipping-changes. If that is OK for you? You might rebase another time, I'm sorry ;-) |
What I wanted to say is, the other work from Ebe already contains the same functionality if I am not completely mistaken. I'll check when I am back from holidays and report back. |
You are right, the copy of the files is already included in #47. I totally missed that... Closing this PR. |
This PR…
adds the - currently static numbered - tile-present/version files to the map archival commands.