-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Change creation of tiles.zip and maps.zip to support very large countries #47
Conversation
537f163
to
8c88065
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I am overlooking it, but I seem to be missing the creation of the .lzma.12 files?
# Create "tile present" file
f = open(outFile + '.lzma.12', 'wb')
f.close()
- 7za / zip commands with other arguments - filling the "new" country-maps folder
- keep or delete the country/region map folders after compression - available via CLI argument
- delete & unify comments - make variables setting less redundant - introduce types for except
a47235c
to
b3e1a37
Compare
Thanks for your feedback! After rebasing this branch with develop and resolving the merge conflicts, the .lzma.12 changes are also visible here: wahooMapsCreator/common_python/osm_maps_functions.py Lines 502 to 505 in 58a3d8f
PS: What do you think of copying the .lzma.12 files to the archive like suggested by @mweirauch in #51? |
:-) You are already including the .lzma.12 files in the archive! It in this PR at line 542 :-) |
You are absolutely right 🥇 Merging this in favor of #51 |
This PR…
extracted from #40: