add allowAnyHttpsCertificate flag on Request #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working through #68 and have concluded that we should not add this to the NS-side of Mac Puppy. Mac can still use
-d:puppyLibcurlto have this flag.Our Mac internals use the old and deprecated (but working great) HTTP APIs from Apple. There is no public API way of setting the flag mentioned in the linked PR. It has also been removed from what I can tell, crashing when attempting to call
request.setAllowsAnyHTTPSCertificate(true, @url.host). Not a big deal. Those that need this flag can just use the define for the time being.