Allow empty commit message with a specified flag #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonathan-Rosenberg
requested review from
nopcoder,
johnnyaug,
talSofer,
guy-har and
itaidavid
|
|
Jonathan-Rosenberg
changed the title
Jonathan-Rosenberg
added
the
include-changelog
johnnyaug
suggested changes
Feb 8, 2022
| @@ -425,6 +425,10 @@ components: | |||
| type: object | |||
| additionalProperties: | |||
| type: string | |||
| date: | |||
|
Commenting here as I couldn't find how to comment on file rename - why was nessie/files/ro_1k renamed to nessie/files/ro_1k.txt? |
itaidavid
reviewed
Feb 8, 2022
itaidavid
reviewed
Feb 8, 2022
nopcoder
suggested changes
Feb 9, 2022
nopcoder
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
--allow-empty-messageflag that allows a commit to have an empty message, i.e.:lakectl commit lakefs://<repo>/<branch> -m "<whitespace character/s or nothing at all>" --allow-empty-messagewill be allowed, yet
lakectl commit lakefs://<repo>/<branch> -m "<whitespace character/s or nothing at all>"will not be allowed.
Closes #1395