Garbage Collector- validate that the written report DataFrame isn't empty #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonathan-Rosenberg
added
the
exclude-changelog
arielshaqed
requested changes
Sep 22, 2022
| concatToGCLogsPrefix(storageNSForHadoopFS, s"deleted_objects/$time/deleted.parquet") | ||
| ) | ||
|
|
||
| spark.close() |
There was a problem hiding this comment.
closes in line 345
| ) | ||
|
|
||
| spark.close() | ||
| if(!removed.isEmpty) { |
There was a problem hiding this comment.
But: this finishes running silently if it succeeded. So any program downstream that needs to process the list of deleted objects now has to have a special-case for a GC run that succeeded without deleting anything.
I would very much prefer a consistent output, of an empty object. There do exist empty Parquet files.
There was a problem hiding this comment.
johnnyaug
approved these changes
Sep 22, 2022
arielshaqed
approved these changes
Sep 22, 2022
|
Also, I think this is worth releasing today any which way. It's a serious boost to usability! |
Jonathan-Rosenberg
deleted the
fix/spark-metaclient/ignore-empty-dataframe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the written DataFrame is not empty before writing it, so that it won't throw an exception.
How was this tested?
I ran the GC in dry-run mode against a repo with ~850K objects to be deleted. It used to fail on that repo but now it finishes successfully.
Fixes #4238