Exclude non-existing objects from absolute addresses list #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talSofer
added
the
exclude-changelog
johnnyaug
approved these changes
Oct 13, 2022
| val hcValues = | ||
| spark.sparkContext.broadcast(HadoopUtils.getHadoopConfigurationValues(hc, "fs.")) | ||
| val configMapper = new ConfigMapper(hcValues) | ||
| absolutePathsDF.filter(x => isPathExist(x, configMapper)) |
There was a problem hiding this comment.
Why not use fs.exists?
Suggested change
| absolutePathsDF.filter(x => isPathExist(x, configMapper)) | |
| absolutePathsDF.filter(x => { | |
| val p = new Path(x) | |
| p.getFileSystem(configMapper.configuration).exists(p) | |
| }) |
There was a problem hiding this comment.
you are absolutely right :) I forgot about it, thanks!
done
There was a problem hiding this comment.
I also think that to unify our usage we should get the FS from the path, and also exists saves a few lines of code, but you should catch IOException, and it might be still implemented under the isPathExist method.
Jonathan-Rosenberg
approved these changes
Oct 13, 2022
johnnyaug
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4366
How was this tested