Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lakectl import #4558

Merged
merged 9 commits into from
Nov 9, 2022
Merged

lakectl import #4558

merged 9 commits into from
Nov 9, 2022

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Nov 6, 2022

Close #4450

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Nov 6, 2022
@nopcoder nopcoder requested a review from a team November 6, 2022 10:06
@nopcoder nopcoder self-assigned this Nov 6, 2022
@nopcoder nopcoder changed the title lakectl import with optional progress bar lakectl import Nov 6, 2022
@nopcoder nopcoder marked this pull request as ready for review November 7, 2022 08:26
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code LGTM! Mostly minor comments.
Please add documentation to the import section.

@@ -2168,6 +2168,29 @@ lakectl help [command] [flags]



### lakectl import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itaiad200 we want to remove the ingest from lakectl in order to have one way to do it?
Currently the "zero copy" import described there is based on the UI capability and the lakectl ingest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, no. The ingest is leaner and more flexible as it creates uncommitted entries instead of entire commits.


var importCmd = &cobra.Command{
Use: "import --from <object store URI> --to <lakeFS path URI> [--merge]",
Short: "Import data from external source to an imported branch (with optional merge)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "external source" is indicative enough. We can only import from object store paths that the lakeFS server has access to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took it from the docs "The lakectl command supports ingesting objects from an external source. This is done by listing the source bucket (and optional prefix), and creating pointers to the returned objects in lakeFS."

cmd/lakectl/cmd/import.go Show resolved Hide resolved
cmd/lakectl/cmd/import.go Outdated Show resolved Hide resolved
cmd/lakectl/cmd/import.go Outdated Show resolved Hide resolved
cmd/lakectl/cmd/import.go Show resolved Hide resolved
docs/setup/import.md Outdated Show resolved Hide resolved
docs/setup/import.md Outdated Show resolved Hide resolved
docs/setup/import.md Outdated Show resolved Hide resolved
nopcoder and others added 3 commits November 9, 2022 16:49
Co-authored-by: itaiad200 <itaiad200@gmail.com>
Co-authored-by: itaiad200 <itaiad200@gmail.com>
Co-authored-by: itaiad200 <itaiad200@gmail.com>
@nopcoder nopcoder enabled auto-merge (squash) November 9, 2022 14:50
@nopcoder nopcoder merged commit 141cf9b into master Nov 9, 2022
@nopcoder nopcoder deleted the feature/lakectl-import branch November 9, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lakectl: allow importing through the CLI
2 participants