Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Chart Type Options | Date Range Filter #30

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Feat: Chart Type Options | Date Range Filter #30

merged 4 commits into from
Apr 2, 2020

Conversation

abshakekumar
Copy link

What:

  • Updated Chart Options that can be selected via DropDown.

3uz372

Why:

  • Good to have some options for Chart type.

How:

  • By default, line chart is selected, and a dropdown is given to change chart type.

  • Select the dropdown to see the chart changing.

@abshakekumar
Copy link
Author

abshakekumar commented Apr 1, 2020

Feat: Added Start and End Date for Filtering Chart Data

A commit has been made to achieve the following issues.
#25 (Feature Request: Add a selectable Date for Start analysis)
#6 ([feature-request] Add filter by range)

Date Range looks like this

Screenshot 2020-04-02 at 2 32 59 AM

@abshakekumar abshakekumar changed the title Feat: Chart Options Via DropDown Feat: Chart Type Options | Date Range Filter for Charts Data Apr 1, 2020
@abshakekumar abshakekumar changed the title Feat: Chart Type Options | Date Range Filter for Charts Data Feat: Chart Type Options | Date Range Filter Apr 1, 2020
js/index.js Outdated Show resolved Hide resolved
js/index.js Show resolved Hide resolved
@trekhleb trekhleb changed the base branch from master to date-range-filter April 2, 2020 06:44
@trekhleb
Copy link
Owner

trekhleb commented Apr 2, 2020

Thanks for the PR, @abshakekumar !
I'm merging it into the date-range-filter branch for now since I want to do some editions and after that I'll merge it into master.

@trekhleb trekhleb merged commit cb85c5c into trekhleb:date-range-filter Apr 2, 2020
@abshakekumar
Copy link
Author

we need to update the formatDateLabel function in data.js as
const options = { year: 'numeric', month: 'short', day: '2-digit' };
Because we need year for proper functioning of Date Range Filter.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants