Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions cannot be extracted from FlowMultipartReply #31

Closed
chibacchie opened this issue Apr 16, 2013 · 4 comments
Closed

instructions cannot be extracted from FlowMultipartReply #31

chibacchie opened this issue Apr 16, 2013 · 4 comments
Assignees

Comments

@chibacchie
Copy link
Member

FlowMultipartReply does not have "insctuctions" and it is not possible to extract instructions from flow stats multipart reply.

@ghost ghost assigned nickkaranatsios Apr 16, 2013
@nickkaranatsios
Copy link
Member

@chibacchie
Currently in openflow.h (OPF1.3.1) (struct ofp_flow_stats) instructions are commented out. Probably instructions required that's why you raised this issue, I would start doing the mods to openflow.h, switch(datapath/switch) and rest of source, please wait for a while since there are lots of changes to be done.

@chibacchie
Copy link
Member Author

Because struct ofp_match is variable length, "instructions" in struct ofp_flow_stats seems to be commented out (similar reason to struct ofp_flow_mod). C library (libtrema) supports to include instructions in struct ofp_flow_stats but Trema Switch and Ruby wrapper do not support it. Open vSwitch includes instructions as a part of flow stats multipart reply.

@nickkaranatsios
Copy link
Member

@chibacchie
This a4a245d commit adds instructions to multipart flow stats reply. Pls confirm. PS. Do a clean build not sure where the problem is but apparently some dependencies don't work well for switch/switch and switch/datapath.

@chibacchie
Copy link
Member Author

@nickkaranatsios Goooood! Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants