Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language dropdown to several forms #117

Merged
merged 14 commits into from
May 28, 2021

Conversation

roxanaopr
Copy link

@roxanaopr roxanaopr commented May 24, 2021

🎩 What? Why?

Add a new language selection dropdown field in various forms, so that the user can choose the language in which he writes the comments, creates the events and / or ideas.Place the new field to be the first element in each form.List of forms:

  • Comment
  • Create idea
  • Edit idea
  • Draft idea
  • Create event
  • Edit event
  • Close event

📌 Related links

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Screenshot from 2021-05-24 11-52-11
Screenshot from 2021-05-24 11-52-01
Screenshot from 2021-05-24 11-51-03
Screenshot from 2021-05-24 11-45-45
Screenshot from 2021-05-24 11-45-23
Screenshot from 2021-05-24 11-44-47
Screenshot from 2021-05-24 11-44-15

♥️ Thank you!

@roxanaopr roxanaopr marked this pull request as draft May 24, 2021 07:20
@roxanaopr roxanaopr changed the title User language preference enhancement Add language dropdown to several forms May 24, 2021
@roxanaopr roxanaopr marked this pull request as ready for review May 26, 2021 11:45
@alecslupu alecslupu changed the base branch from develop to fix-foe May 27, 2021 03:11
@alecslupu alecslupu merged commit b2e939b into fix-foe May 28, 2021
@alecslupu alecslupu deleted the feature/add-language-selector branch June 18, 2021 09:32
@alecslupu alecslupu restored the feature/add-language-selector branch September 30, 2021 17:14
@alecslupu alecslupu deleted the feature/add-language-selector branch September 30, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants