Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close meeting in public pages #16

Merged
merged 11 commits into from
Oct 19, 2020

Conversation

mllocs
Copy link

@mllocs mllocs commented Oct 14, 2020

What? Why?

Implement "Close meeting" action in the public pages.

Testing

Meeting organisers can close the meeting from the public page. When doing that, they can add a closing report and link proposals.

Screenshots

Screen Shot 2020-10-14 at 11 38 47
Screen Shot 2020-10-14 at 11 39 36

@oriolgual
Copy link

Should we add some system tests?

@mllocs mllocs marked this pull request as ready for review October 16, 2020 12:39
@mllocs mllocs requested a review from mrcasals October 16, 2020 14:29
Copy link

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good job! 😄

@mrcasals mrcasals merged commit efb0e88 into fix-foe Oct 19, 2020
@mrcasals mrcasals deleted the feature/close-meeting-in-public-pages branch October 19, 2020 08:03
@mrcasals mrcasals restored the feature/close-meeting-in-public-pages branch October 19, 2020 08:14
@mrcasals mrcasals deleted the feature/close-meeting-in-public-pages branch October 19, 2020 08:17
@mrcasals mrcasals restored the feature/close-meeting-in-public-pages branch October 19, 2020 08:19
@mrcasals mrcasals deleted the feature/close-meeting-in-public-pages branch October 19, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants