Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small improvements #1619

Merged
merged 10 commits into from
May 9, 2022
Merged

Some small improvements #1619

merged 10 commits into from
May 9, 2022

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented May 6, 2022

Pull request

Description

Related

  • RFC
  • Related Issues: fixes #000, closed #000
  • Related docs PR

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Licenser
Licenser previously approved these changes May 6, 2022
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1619 (a7785f6) into main (80b7e34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   85.61%   85.62%           
=======================================
  Files         232      232           
  Lines       47109    47109           
=======================================
+ Hits        40334    40338    +4     
+ Misses       6775     6771    -4     
Flag Coverage Δ
unittests 85.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connectors/impls/metronome.rs 98.63% <100.00%> (+1.40%) ⬆️
src/system/flow_supervisor.rs 86.44% <100.00%> (+0.72%) ⬆️
src/connectors.rs 85.91% <0.00%> (-0.31%) ⬇️
src/pipeline.rs 76.66% <0.00%> (-0.28%) ⬇️
src/system/flow.rs 89.90% <0.00%> (-0.20%) ⬇️
tremor-value/src/value.rs 98.99% <0.00%> (+0.09%) ⬆️
src/connectors/source/channel_source.rs 80.00% <0.00%> (+1.66%) ⬆️
src/version.rs 87.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b7e34...a7785f6. Read the comment docs.

@coveralls
Copy link
Collaborator

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2293068634

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 88 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.06%) to 85.627%

Files with Coverage Reduction New Missed Lines %
src/system/flow.rs 1 89.9%
src/system/flow_supervisor.rs 1 86.44%
src/connectors.rs 2 85.91%
src/pipeline.rs 84 76.67%
Totals Coverage Status
Change from base Build 2292922964: -0.06%
Covered Lines: 40338
Relevant Lines: 47109

💛 - Coveralls

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Users don't necessarily need to know, they will get a timeout error message anyways.

Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
@mfelsche mfelsche force-pushed the integration-elastic-unique branch from c2cd387 to ec79225 Compare May 9, 2022 08:21
Licenser
Licenser previously approved these changes May 9, 2022
@Licenser Licenser merged commit 7038a53 into main May 9, 2022
@Licenser Licenser deleted the integration-elastic-unique branch May 9, 2022 09:55
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants