-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some small improvements #1619
Some small improvements #1619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 85.61% 85.62%
=======================================
Files 232 232
Lines 47109 47109
=======================================
+ Hits 40334 40338 +4
+ Misses 6775 6771 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 2293068634
💛 - Coveralls |
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Users don't necessarily need to know, they will get a timeout error message anyways. Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
c2cd387
to
ec79225
Compare
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Pull request
Description
Related
Checklist
Performance