Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectBox is missing the props required and name #366

Closed
lucafaggianelli opened this issue Mar 23, 2023 · 14 comments · Fixed by #931
Closed

SelectBox is missing the props required and name #366

lucafaggianelli opened this issue Mar 23, 2023 · 14 comments · Fixed by #931
Assignees
Labels
Good first issue Beginner-friendly issue for first-time contributors Type: Enhancement Small enhancement to existing component or feature

Comments

@lucafaggianelli
Copy link
Contributor

I'm using the standard HTML form element so it would be nice to have the name property to handle form data on submit.

SelectBox it's also missing the required property.

@mitrotasios
Copy link
Member

Good points, we'll try to add these props!

@mitrotasios mitrotasios added the Type: Enhancement Small enhancement to existing component or feature label Mar 23, 2023
@jorgeramirezamora
Copy link

@mitrotasios can u give some guidance in where to start? I can add those

@mitrotasios
Copy link
Member

hey @jorgeramirezamora thanks for offering this, we are currently working on migrating our Input elements to use headlessui as it would enable us to make them easily accessible. So I think it wouldn't make sense to start working on this issue until the migration is complete. Should I get back to you once this is the case? Also, feel free to join our Slack community and we can chat about delegating other tasks to you if you're interested in contributing!

@jorgeramirezamora
Copy link

Makes sense. And yes please, I am interested in contributing 🚀 How can I join Tremor's Slack?

@mitrotasios
Copy link
Member

Awesome! Here’s the link: https://t.co/g99pltTvIC

@severinlandolt severinlandolt added the Good first issue Beginner-friendly issue for first-time contributors label Sep 7, 2023
@christopherkindl
Copy link
Member

Hey @jorgeramirezamora, the select boxes now run on Headless UI and we still need to add id and name and some underlying changes to use them in forms. Let me know if you want to contribute here!

@jorgeramirezamora
Copy link

Sure, lemme wrap up #670 first

@christopherkindl
Copy link
Member

@jorgeramirezamora awesome, thanks!

@jzfrank
Copy link
Contributor

jzfrank commented Oct 1, 2023

I would like to be assigned for this. :)

@Ramin-Khodaie
Copy link

I am using SelectBox and MultiSelectBox in a form and here I dont have props like required and name for them.
I'm using tremor V2.0.1
is there any idea how to deal with this?

@mbauchet
Copy link
Collaborator

There is already a PR (#729) on this

Copy link

🎉 This issue has been resolved in version 3.13.2-beta-select.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 3.13.4-beta-select.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 3.13.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Beginner-friendly issue for first-time contributors Type: Enhancement Small enhancement to existing component or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants