Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: selectbox missing required name (#729) (#925) #931

Merged
merged 7 commits into from
Jan 30, 2024
Merged

fix: selectbox missing required name (#729) (#925) #931

merged 7 commits into from
Jan 30, 2024

Conversation

severinlandolt
Copy link
Member

@severinlandolt severinlandolt commented Jan 23, 2024 •
edited
Loading

Description

This PR imporves form support of all Select Components.

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Storybook

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@severinlandolt @jzfrank
@christopherkindl @iamtouha @mbauchet
fix: selectbox missing required name (#729) (#925)
47159be 
* fix: selectbox missing required name (#729)

---------

Co-authored-by: jzfrank <77217626+jzfrank@users.noreply.github.com>
Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Co-authored-by: Touha Zohair <39002455+touha98@users.noreply.github.com>
Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: severinlandolt <sev.landolt@gmail.com>
Co-authored-by: mbauchet <maximebauchet26@gmail.com>
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 1:53pm

@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Jan 28, 2024
@severinlandolt
Revert "fix: remove w-full"
cfaff43 
This reverts commit 718c44c.
@severinlandolt severinlandolt merged commit c58653c into main Jan 30, 2024
7 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.13.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherkindl christopherkindl christopherkindl approved these changes

Assignees
No one assigned
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
2 participants
@severinlandolt @christopherkindl