Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Grid RSC compliant, again #639

Merged
merged 2 commits into from Sep 7, 2023
Merged

fix: make Grid RSC compliant, again #639

merged 2 commits into from Sep 7, 2023

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Aug 26, 2023 •
edited

Description

This fixes an undocumented breaking change where Grid can no longer be rendered as a server component (ie. in Next.js 13's app dir)

This removes useMemo from Grid, enabling it to render as a server component.

  • Acknowledging that that adding the 'use client'; directive is another option, but less ideal.

Note

Grid used to be server-component compliant up until this diff in #499

Related issue(s)

N/A

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

When upgrading from v2.8.2 to v3.6.6, I encountered this error.
CleanShot 2023-08-26 at 12 05 06@2x

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.

@thiskevinwang thiskevinwang changed the title (Grid): make it RSC compliant fix(Grid): make it RSC compliant Aug 26, 2023
@thiskevinwang thiskevinwang changed the title fix(Grid): make it RSC compliant fix(Grid): make it RSC compliant, again Aug 26, 2023
@severinlandolt severinlandolt added PR: Under Consideration Has potentially wider implications which are being discussed PR: In Review This PR is in the process of being reviewed by the team and removed PR: Under Consideration Has potentially wider implications which are being discussed labels Aug 31, 2023
@severinlandolt severinlandolt changed the title fix(Grid): make it RSC compliant, again fix: make Grid it RSC compliant, again Aug 31, 2023
@severinlandolt severinlandolt self-assigned this Aug 31, 2023
@thiskevinwang thiskevinwang changed the title fix: make Grid it RSC compliant, again fix: make Grid RSC compliant, again Sep 2, 2023
@severinlandolt severinlandolt merged commit 3d40d64 into tremorlabs:main Sep 7, 2023
6 checks passed
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🎉 This PR is included in version 3.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severinlandolt severinlandolt severinlandolt approved these changes

Assignees

@severinlandolt severinlandolt

Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thiskevinwang @severinlandolt