feat: Tooltip for Buttons #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitstart
changed the title
gitstart
force-pushed
the
feat/add-tooltip-for-buttons
branch
2 times, most recently
from
52b34f8
to
e2150d1
Compare
gitstart
changed the title
|
👋 Hello @mitrotasios! Can you review this PR, please? |
mitrotasios
suggested changes
May 27, 2023
we will work on it and get back to you soon. |
|
Hello @mitrotasios |
gitstart
force-pushed
the
feat/add-tooltip-for-buttons
branch
from
0cdfe1e
to
7c19d9e
Compare
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Rubens Rafael <70234898+RubensRafael@users.noreply.github.com>
gitstart
force-pushed
the
feat/add-tooltip-for-buttons
branch
from
7c19d9e
to
7522196
Compare
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Seems like there's no straightforward way to style the tooltip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #471
What: Add the possibility to use tooltips on button component
Why: To be able to use tooltips in this component
How: The changes was implemented following the components
src/components/icon-elements/Icon/Icon.tsxandsrc/components/icon-elements/Badge/Badge.tsx, they already have a tooltip componentTesting
run:
Demo
Loom Video: https://www.loom.com/share/5181bda86a65435b8f6298ba92dfb493
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.