Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scatter chart with basic tooltip and axis value formatters #586

Merged

Conversation

mbauchet
Copy link
Collaborator

Description

Add scatter chart component
Related issue(s)
#563

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):
Capture d’écran 2023-07-25 à 20 46 32

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.

@mbauchet mbauchet mentioned this pull request Jul 25, 2023
13 tasks
@severinlandolt
Copy link
Member

severinlandolt commented Jul 27, 2023

Hi @mbauchet, thank you for your great work, the component looks very good 👍 I just spent some time on the branch, trying to clip the bubbles that overflow the grid area (yellow). But no success using CSS overflow clip/hidden. Also setting margins like {{top: 0, right: 0, bottom: 0, left: 0,}} did not work for all cases (i.e.I was setting "magic values" like -59, only working for certain breakpoints)
CleanShot 2023-07-26 at 22 52 42@2x

In any case, if you have an idea how to clip the area like here, that would be awesome, otherwise it's alright.
CleanShot 2023-07-26 at 23 06 13@2x

@mbauchet
Copy link
Collaborator Author

I'll check today if I can find something... I'll let you inform

@mbauchet
Copy link
Collaborator Author

mbauchet commented Jul 27, 2023

Didn't find an easy way to accomplish it for now... Except adding padding to X and Y axis to avoid axis values to be hidden, but not entirely convinced by the result...
image

At least, we should add margin on the right side in order to have the same overflowing on each sides
Capture d’écran 2023-07-27 à 08 30 45

@severinlandolt
Copy link
Member

Thank you for researching, we will handle the margin, thanks!

@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Jul 28, 2023
@mitrotasios mitrotasios changed the base branch from main to beta-3.6.0.1 July 29, 2023 20:26
@mitrotasios mitrotasios merged commit a4cc8af into tremorlabs:beta-3.6.0.1 Jul 29, 2023
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.6.0-beta-3.6.0.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mbauchet mbauchet deleted the feat/scatterchart-default-tooltip branch September 25, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants