Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show/hide value in text input password #615

Merged
merged 3 commits into from Oct 1, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 9, 2023

Fixes #530

Demo

https://www.loom.com/share/a5e7e0b4415a460ea165ad239121dcfc

What

Display the entered password value to the user

Why

because now users can't see what they typed since the password type field hides the value

How

Adding a button that switches input types when clicked, displaying the password when the type is text

Testing

npm run storybook

and go to TextInput -> With Type Password


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@gitstart gitstart changed the title feat: Show/hide value in text input password (TRMR-OSS-48) feat: Show/hide value in text input password Aug 9, 2023
@gitstart
Copy link
Contributor Author

gitstart commented Aug 9, 2023

Hello @mitrotasios and @christopherkindl !
Could you review this PR, please?

@gitstart gitstart marked this pull request as ready for review August 9, 2023 12:52
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Sep 17, 2023
@severinlandolt severinlandolt changed the base branch from main to beta September 25, 2023 15:22
@severinlandolt severinlandolt self-assigned this Sep 25, 2023
@severinlandolt severinlandolt changed the base branch from beta to main September 26, 2023 11:57
@severinlandolt severinlandolt changed the base branch from main to beta October 1, 2023 13:33
@severinlandolt severinlandolt merged commit e6559d4 into tremorlabs:beta Oct 1, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

🎉 This PR is included in version 3.9.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Show/hide value in text input password
2 participants