New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve readability of multiselect #638
feat: improve readability of multiselect #638
Conversation
Thank you so much, @jzfrank! We will review it asap. |
f65503c
to
83dd575
Compare
@jzfrank Works great so far, one thing to be fixed would be to add a white background for the global close button, such that it does not overlay with the selected items: |
@jzfrank + no change in height of the input bar when an item is selected. Currently it gets bigger once an item is selected 🙂 |
…ox same height before and after select
@christopherkindl Thanks for the review! Now it should get fixed. |
A quick follow up question: I hide the horizontal scrollbar for a better UI. However, if the user does not have a trackpad or ability to scroll horizontally, should we show the scrollbar? Maybe we should add a prop |
Thanks so much @jzfrank! Will review it asap. And good question, will try out what feels better. |
@christopherkindl @jzfrank Added support for dark mode. |
@jzfrank updated styling of selected items |
@christopherkindl Should now have the same height: |
51e925e
to
c0f0dcf
Compare
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Improve readability of selected items in
MultiSelect
Related issue(s)
#635
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has This been tested?
Storybook
Screenshots (if appropriate):
lg
as breakpointIn mobile:
horizontally scrollable without showing scroll bar.
In desktop:
The PR fulfills these requirements:
main
branch