Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add weekStartsOn to DatePicker and DateRangePicker #643

Conversation

jzfrank
Copy link
Contributor

@jzfrank jzfrank commented Aug 28, 2023

Description

Add weekStartsOn option to DatePicker and DateRangePicker.

This PR is very similar to #625 and tests are inspired by it, but also does so for dateRangePicker.

The maintainer of tremor should choose whatever they see fit.

Related issue(s)
#552

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

In storybook. Tested DateRangePicker and DatePicker with different weekStartsOn

Screenshots (if appropriate):
datePicker with week starting on Wednesday:
image

dateRangePicker with week starting on Tuesday:
image

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.

@jzfrank jzfrank marked this pull request as ready for review August 28, 2023 11:34
@severinlandolt severinlandolt self-assigned this Aug 30, 2023
@severinlandolt severinlandolt added Status: Review needed The issue/feature should be reviewed Type: Enhancement Small enhancement to existing component or feature PR: Documentation Needed This PR warrants a documentation update labels Aug 30, 2023
@severinlandolt severinlandolt merged commit 86e284d into tremorlabs:main Sep 2, 2023
9 checks passed
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Documentation Needed This PR warrants a documentation update Status: Review needed The issue/feature should be reviewed Type: Enhancement Small enhancement to existing component or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants