Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add on click event to ScatterChart #672

Merged
merged 11 commits into from Sep 20, 2023
Merged

feat: Add on click event to ScatterChart #672

merged 11 commits into from Sep 20, 2023

Conversation

mbauchet
Copy link
Collaborator

Description
Adding on click event to ScatterChart

Related issue(s)
#195

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?
Storybook

Screenshots (if appropriate):
Capture d’écran 2023-09-13 à 13 32 27

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.

@severinlandolt
Copy link
Member

Looks awesome, it's a 100% what we imagined, thank you @mbauchet 🤩

@severinlandolt severinlandolt added Type: Docs Indicates that the documentation is affected. Either add or correct docs. PR: In Review This PR is in the process of being reviewed by the team labels Sep 14, 2023
@severinlandolt severinlandolt linked an issue Sep 14, 2023 that may be closed by this pull request
onClick Handler on Tremor Charts #195
Closed
@severinlandolt severinlandolt added PR: Documentation Needed This PR warrants a documentation update and removed Type: Docs Indicates that the documentation is affected. Either add or correct docs. labels Sep 14, 2023
@severinlandolt severinlandolt changed the base branch from main to beta September 20, 2023 10:31
@severinlandolt severinlandolt merged commit ceb2421 into tremorlabs:beta Sep 20, 2023
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.8.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 24, 2023
Merged
Merged
@mbauchet mbauchet deleted the feat/on-click-event-scatter branch September 25, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Documentation Needed This PR warrants a documentation update PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onClick Handler on Tremor Charts
2 participants
@mbauchet @severinlandolt