feat: enableClear option for SearchSelect component #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudham Jayanthi <workwithsudham@gmail.com>
|
thanks for the changes @severinlandolt! can we merge this? |
|
Yes, will be included in the next minor version. |
severinlandolt
added
the
PR: In Review
|
Sorry, will make it into v3.9 |
|
hey @severinlandolt, do we have a estimated release date for v3.9? |
|
ca. mid October |
|
🎉 This PR is included in version 3.9.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the enableClear functionality in
SearchSelectsimilar toSearchcomponent.Related issue(s)
#680 (comment)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Screenshots (if appropriate):
The PR fulfills these requirements:
mainbranchPS: I needed this for my project, but thought it would be better to contribute for everyone else like me. Feel free to let me know if any changes are required :) Otherwise kindly merge it!