Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DateRangePicker clear #689

Merged

Conversation

sudhamjayanthi
Copy link
Contributor

@sudhamjayanthi sudhamjayanthi commented Sep 17, 2023

Description
Fixes a bug with DateRangePicker clear

Related issue(s)
#688

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?
Manually tested in storybook :P

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.

It now clears both DatePicker and Range fields
@severinlandolt severinlandolt linked an issue Sep 25, 2023 that may be closed by this pull request
@severinlandolt severinlandolt changed the base branch from main to beta September 26, 2023 17:24
@severinlandolt severinlandolt merged commit 83cf230 into tremorlabs:beta Sep 26, 2023
12 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.8.1-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

🎉 This PR is included in version 3.9.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DatePickerRange clear doesn't clear Range field
2 participants