Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onClick Bar Chart and DonutChart #696

Merged
merged 2 commits into from Sep 19, 2023
Merged

Conversation

severinlandolt
Copy link
Member

@severinlandolt severinlandolt commented Sep 19, 2023

This PR adds OnClick behaviour for Bar Chart and Donut (Pie) Chart

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • [] When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

severinlandolt and others added 2 commits September 5, 2023 06:47
* Adds on click for donut chart and line chart

Co-authored-by: Severin Landolt <sev.landolt@gmail.com>
Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: mbauchet <90607026+mbauchet@users.noreply.github.com>
Co-authored-by: Maxime BAUCHET <maxime.bauchet@insystem.fr>
@severinlandolt severinlandolt merged commit 00bb469 into beta Sep 19, 2023
6 checks passed
@severinlandolt severinlandolt deleted the feat/on-click-events branch September 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants