Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: divider label with children #719

Merged
merged 3 commits into from Oct 1, 2023
Merged

feat: divider label with children #719

merged 3 commits into from Oct 1, 2023

Conversation

severinlandolt
Copy link
Member

Description

Adds children prop to divider

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):
CleanShot 2023-10-01 at 13 35 45@2x

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@severinlandolt severinlandolt linked an issue Oct 1, 2023 that may be closed by this pull request
[Feature]: Text label for divider #720
Closed
@severinlandolt severinlandolt changed the title Feat/dividerlabel featL divider label with children Oct 1, 2023
@severinlandolt severinlandolt changed the title featL divider label with children feat: divider label with children Oct 1, 2023
@severinlandolt severinlandolt self-assigned this Oct 1, 2023
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Oct 1, 2023
@severinlandolt severinlandolt merged commit d12d51f into beta Oct 1, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

🎉 This PR is included in version 3.9.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@severinlandolt severinlandolt deleted the feat/dividerlabel branch October 8, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@severinlandolt severinlandolt

Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Text label for divider
1 participant
@severinlandolt