fix: static and dynamic children #792
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
motinados
changed the title
severinlandolt
added
the
PR: In Review
|
Man, you are as fast as it gets! Was about to fix the tests and got notified: |
|
I will return it to draft for now as there is something of concern. |
|
@severinlandolt @mbauchet |
|
Thank you very much, your contributions are highly appreciated @motinados! 🙏 |
|
🎉 This PR is included in version 3.11.1-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @motinados, the mapping is now working fine locally and in my test projects. There has been one issue with unresolved promises. E.g. if data comes from Tanstack query it will be undefined until the promise is resolved. Resulting in this error: TypeError: Cannot read properties of null (reading 'props')
at selectutils
at mapIntoArray
at mapIntoArray
at Object.mapChildren [as map]
at 011 selectutils
at updateMemo
at Object.useMemo
at useMemo
mbauchet pointed out, that the problem might be the Could you take a look at this issue? Feel free to create a new branch from |
|
@severinlandolt @mbauchet I did encounter a similar error when the data retrieved with Tanstack query contains null, but it appears at the value={String(coworker.fullname)} in SearchSelectItem. Since undefined until the promise is resolved filtered out using isValidElement, I believe it should not be a problem. Could there be some cache remaining? If you are using a Next.js app, please try deleting the .next folder and testing again. |
) * fix: select height and autofocus (#796) * add autofocus handler * Fix selection height * fix: static and dynamic children (#792) * fix: Switch color (#802) --------- Co-authored-by: motinados <69296148+motinados@users.noreply.github.com> Co-authored-by: mbauchet <90607026+mbauchet@users.noreply.github.com>
|
🎉 This PR is included in version 3.12.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.12.0-beta-package-updates.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.12.0-beta-customcolors.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@motinados Heya! One user reported an issue about the children prop. I don't quite understand what is going wrong, because lit looks OK to me actually: |
Description
The cause of this error is the constraint on the children's type. To resolve it, the type of children has been changed to ReactNode.
Related issue(s)
Fixes #686
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has This been tested?
jest and storybook
Screenshots (if appropriate):
The PR fulfills these requirements:
mainbranch