Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: findDOMNode is deprecated in StrictMode #907

Merged
merged 3 commits into from
Jan 15, 2024
Merged

fix: findDOMNode is deprecated in StrictMode #907

merged 3 commits into from
Jan 15, 2024

Conversation

iamtouha
Copy link
Contributor

Description
react-transition-group is removed and replaced with react-transition-state.

Related issue(s)
fixes #816

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?
The issue was reproduced to check if there's any error in console.

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@severinlandolt severinlandolt self-assigned this Jan 15, 2024
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Jan 15, 2024
@severinlandolt severinlandolt changed the base branch from main to beta-button-transition January 15, 2024 10:06
@severinlandolt
Copy link
Member

@iamtouha 🫡

@severinlandolt severinlandolt merged commit 7cdb01d into tremorlabs:beta-button-transition Jan 15, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.13.2-beta-button-transition.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamtouha iamtouha deleted the fix/findDomNode-deprecated branch January 15, 2024 10:38
severinlandolt added a commit that referenced this pull request Jan 23, 2024
@severinlandolt @iamtouha
fix: findDOMNode is deprecated in StrictMode (#907) (#924)
435a740 
* Add react-transition-state library

* replace `react-transition-group` with `react-transition-state`

* Remove react-transition-group package

Co-authored-by: Touha Zohair <39002455+iamtouha@users.noreply.github.com>
severinlandolt added a commit that referenced this pull request Jan 23, 2024
@severinlandolt @iamtouha @christopherkindl
fix: export CustomTooltipProps and fix button transition (#930)
7e857c5 
* fix: findDOMNode is deprecated in StrictMode (#907) (#924)

* Add react-transition-state library

* replace `react-transition-group` with `react-transition-state`

* fix: reconfigure CustomTooltipProps

* fix: add theme tokens to legend slider (#929)

---------

Co-authored-by: Touha Zohair <39002455+iamtouha@users.noreply.github.com>
Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@severinlandolt severinlandolt

Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
2 participants
@iamtouha @severinlandolt