Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scale props to sparkcharts #950

Merged

Conversation

mbauchet
Copy link
Collaborator

@mbauchet mbauchet commented Feb 6, 2024

Description

Related issue(s)
Closes #949

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Screenshots (if appropriate):

Capture d’écran 2024-02-06 à 22 01 47

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 8:59pm

@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Feb 9, 2024
@severinlandolt severinlandolt changed the base branch from main to beta February 9, 2024 00:38
@severinlandolt severinlandolt linked an issue Feb 9, 2024 that may be closed by this pull request
@severinlandolt severinlandolt merged commit 172facc into tremorlabs:beta Feb 9, 2024
14 checks passed
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 3.14.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 3.14.0-beta-barlist.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

severinlandolt added a commit that referenced this pull request Feb 9, 2024
* fix: add shrink-0

* fix: remove double shadow date range picker (#953)

* add icon flex story

* fix: badge dark mode

* fix: BadgeDelta dark mode, Table

* feat: Add scale props to sparkcharts (#950)

* add autominValue, minValue, maxValue to spark charts

* feat: Add onValueChange props to BarList (#948)

* add onvaluechange prop

* fix: add generic data barlist (#957) (#960)

* add onvaluechange prop

* fix lint

* add generic data

* fix lint

---------

Co-authored-by: mbauchet <90607026+mbauchet@users.noreply.github.com>
Co-authored-by: Maxime BAUCHET <maxime.bauchet@insystem.fr>

* chore: update readme

* update readme

* update logo dark mode

* feat: Added searchValue and onSearchValueChange props on SearchSelect (#944) (#958)

* Adds searchValue and onSearchValueChange props

---------

Co-authored-by: Perry Raskin <perryraskin@gmail.com>

* fix: trigger release

---------

Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Co-authored-by: mbauchet <90607026+mbauchet@users.noreply.github.com>
Co-authored-by: Maxime BAUCHET <maxime.bauchet@insystem.fr>
Co-authored-by: Perry Raskin <perryraskin@gmail.com>
severinlandolt added a commit that referenced this pull request Feb 11, 2024
…ta and for barlist, new props for SearchSelect, new readme (#963)

* fix: remove double shadow date range picker (#953)

* fix: BadgeDelta dark mode, Table

* feat: Add scale props to sparkcharts (#950)

* feat: Add onValueChange props to BarList (#948)

* fix: add generic data barlist (#957) (#960)

* chore: update readme

* feat: Added searchValue and onSearchValueChange props on SearchSelect (#944) (#958)

Co-authored-by: Perry Raskin <perryraskin@gmail.com>
Co-authored-by: christopherkindl <53372002+christopherkindl@users.noreply.github.com>
Co-authored-by: mbauchet <90607026+mbauchet@users.noreply.github.com>
Co-authored-by: Perry Raskin <perryraskin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Better handle scale in spark charts
2 participants