Fix list conversion issues in the xml gatherer #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand the complexity of the task and golang is really verbose, could we add some comments through the function? Just to have a better understanding of whats'happening? Due to all the casting I don't think we can achieve a really better refactoring, so the comments imho are the best way to address this right now :D |
nelsonkopliku
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Did you say interface{}? 😄
LGTM. If some comment help, as @CDimonaco is suggesting, it'd be ok for me.
CDimonaco
requested changes
Dec 22, 2022
CDimonaco
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last sprint review I noticed that in some corner cases, the conversion to list was doing something strange.
At the end I have been forced to change how it was, adding some recursive code to convert the desired fields to list properly.
The code might looks complex, what it is what is is in this sort of things on golang...