Add new documentation about the runner component #191
Conversation
arbulu89
requested review from
fabriziosestito,
rtorrero,
stefanotorresi and
aleksei-burlakov
|
Hey @arbulu89, I think you forgot to update the index on the top of the document :-) Appart from that, lgtm |
README.md
Outdated
|
|
||
| # Enable the SSH connections to the agents machines | ||
| # Update the /etc/hosts file to identify the agents hosts | ||
| # Authorize SSH connection for all the agents hosts |
There was a problem hiding this comment.
I am a bit confused about this part, even if it works fine by adding the entries to the /etc/hosts files I wouldn't ask the user to do so. We already have a service discovery in place, we might want to use that.The consul server DNS should be possibly used to resolve the nodes.
EDIT:
Just found out that we can add ansible_host=<node_ip> to the ansible inventory to allow ansible to "resolve" the hosts, this is quite easy to do in the ansible template generation, we tested it and it works as expected. See: https://docs.ansible.com/ansible/latest/reference_appendices/special_variables.html#connection-variables
There was a problem hiding this comment.
The code updated to work without editing the host file.
I will update the comments here to make sure that the unique mandatory part is the ssh authorization
|
@rtorrero @fabriziosestito Content updated with your suggestions |
README.md
Outdated
| ssh-copy-id 192.168.100.1 | ||
|
|
||
| # Start the Trento runner | ||
| ./trento runner start --ara-server http://araIP:port --consul-add consulIP:port -i 5 |
There was a problem hiding this comment.
Typo here...
--consul-addr
|
@fabriziosestito @rtorrero This is ready to be reviewed too! |
|
@fabriziosestito @rtorrero @stefanotorresi |
arbulu89
dismissed
rtorrero’s stale review
Changes done and approved by Fabrizio
New entry in the README file about the usage of the trento runner.
I would appreciate if anyway follows the quickstart to see if it works fine