This repository has been archived by the owner on May 30, 2022. It is now read-only.
Add ansible_host connection option to ansibleHostsTemplate #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
arbulu89,
aleksei-burlakov,
rtorrero and
stefanotorresi
arbulu89
approved these changes
Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ansible_hostconnection option to the generated ansible inventory by using the node discovered IP address.See: https://docs.ansible.com/ansible/latest/reference_appendices/special_variables.html#connection-variables
This is required in order to let ansible know the ip of the hosts without resolving them, so we don't ask the user to modify
/etc/hostsor alter `resolv.conf/k8s core dns or pod dns policies.See: #191 (comment)