This repository has been archived by the owner on May 30, 2022. It is now read-only.
check 1.1.9 (DA114A): to scan node-directives for both rings #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note to self: needs forward-port into runner |
|
Looks good for me. I vote to merge this PR. |
|
implemented in trento-project/runner#38 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of counting the string "interface" the test needs to scan the corosync.conf file for the directices node { ... }. There must be exact 2 such node-directives for the current se case and each of the entries needs exact two ring-addresses to be configured.
The perl-snipset outputs a "2" per found node-directive (if exactly 2 rings are found). So the correct result following the best practice is "22" (both name-directives have exact two ring-address definitions).