Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements in ASCS/ERS and HANA cluster details view #1479

Merged
merged 4 commits into from Jun 1, 2023

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jun 1, 2023

Description

UX improvemnts in ASCS/ERS and HANA cluster details page.

Have a look in storybook (HanaClusterDetails and AscsErsClusterDetails).
Changes:

  • Add horizontal space in stopped resources elements
  • Add vertical space in SBD devices
  • Align Checks coming soon image to the center
  • Align dotted pagination of the SAP systems box in the bottom

The alignment of the 2 top boxes in the ASCS/ERS clusters view is excluded, as it doesn't have a trivial fix. @jagabomb told me that he was fine with the current state, but we can create a new ticket to track this if he wants

How was this tested?

Describe what kind of tests for this functionality have been added.

@arbulu89 arbulu89 added enhancement New feature or request ux labels Jun 1, 2023
@arbulu89 arbulu89 changed the title Ascs ers ux improvements UX improvements in ASCS/ERS and HANA cluster details view Jun 1, 2023
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

Copy link
Contributor

@jagabomb jagabomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @arbulu89

@arbulu89 arbulu89 merged commit ed0f400 into main Jun 1, 2023
19 checks passed
@arbulu89 arbulu89 deleted the ascs-ers-ux-improvements branch June 1, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Development

Successfully merging this pull request may close these issues.

None yet

4 participants