Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvements in ASCS/ERS and HANA cluster details view #1479

Merged
merged 4 commits into from
Jun 1, 2023
Merged

UX improvements in ASCS/ERS and HANA cluster details view #1479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e6f9a2
Add horizontal spacing in stopped resources
arbulu89 May 31, 2023
b1c1b6e
Add vertical spacing in sbd devices
arbulu89 May 31, 2023
53563eb
Align dotted pagination using bottom margin
arbulu89 May 31, 2023
daf5ec9
Align checks coming soon image in the center
arbulu89 May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions assets/js/components/ClusterDetails/AscsErsClusterDetails.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ function AscsErsClusterDetails({
]}
/>
</div>
<div className="mt-4 bg-white shadow rounded-lg py-8 px-8 xl:w-2/5 mr-4">
<div className="flex flex-col mt-4 bg-white shadow rounded-lg pt-8 px-8 xl:w-2/5 mr-4">
<ListView
className="grid-rows-2 mb-10"
className="grid-rows-2"
titleClassName="text-lg"
orientation="vertical"
data={[
Expand All @@ -138,19 +138,19 @@ function AscsErsClusterDetails({
},
]}
/>
<div className="flex justify-center">
<div className="flex justify-center mt-auto pt-8 mb-2">
<DottedPagination
pages={sapSystems}
onChange={setCurrentSapSystem}
/>
</div>
</div>
<div className="mt-4 bg-white shadow rounded-lg py-4 xl:w-1/4">
<div className="flex flex-col items-center">
<div className="flex flex-col items-center h-full">
<h1 className="text-center text-2xl font-bold">Check Results</h1>
<h6 className="opacity-60 text-xs">Coming soon for ASCS/ERS</h6>
<img
className="w-full"
className="h-full inline-block align-middle"
alt="checks coming soon"
src={ChecksComingSoon}
/>
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/ClusterDetails/SBDDetails.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function SBDDetails({ sbdDevices }) {
<h2 className="text-2xl font-bold">SBD/Fencing</h2>
</div>
</div>
<div className="mt-2 bg-white shadow rounded-lg py-4 px-8 tn-sbd-details">
<div className="mt-2 bg-white shadow rounded-lg py-4 px-8 space-y-2 tn-sbd-details">
{sbdDevices.map(({ device, status }) => (
<div key={device}>
{getStatusPill(status)} {device}
Expand Down
2 changes: 1 addition & 1 deletion assets/js/components/ClusterDetails/StoppedResources.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function StoppedResources({ resources }) {
<div className="flex flex-direction-row">
<h2 className="text-2xl font-bold self-center">Stopped resources</h2>
</div>
<div className="mt-2">
<div className="mt-2 space-x-2">
{resources.map(({ id }) => (
<Pill className="bg-gray-200 text-gray-800" key={id}>
{id}
Expand Down