Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance deregistration sagas #1746

Merged
merged 4 commits into from Aug 29, 2023
Merged

Instance deregistration sagas #1746

merged 4 commits into from Aug 29, 2023

Conversation

arbulu89
Copy link
Contributor

Description

Add instances deregistration sagas.

It skips by now the navigation part. I guess we should navigate from the SAP system/Database details view when all the instances are deregistered. But it is not trivial, so I think it will be better to work on that once we have the whole flow working, as i'm not sure how it will behave.

How was this tested?

Tests added

@arbulu89 arbulu89 added the enhancement New feature or request label Aug 24, 2023
@arbulu89 arbulu89 marked this pull request as ready for review August 24, 2023 14:31
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only minor comments on naming / tests description

assets/js/state/sagas/databases.test.js Outdated Show resolved Hide resolved
assets/js/state/databases.js Outdated Show resolved Hide resolved
assets/js/state/sagas/sapSystems.test.js Outdated Show resolved Hide resolved
@arbulu89 arbulu89 force-pushed the instance-deregistration-sagas branch from 2c9dfc4 to 93eace3 Compare August 29, 2023 10:23
@arbulu89 arbulu89 merged commit 7343c8a into main Aug 29, 2023
24 checks passed
@arbulu89 arbulu89 deleted the instance-deregistration-sagas branch August 29, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants