Saptune details view #1865
Merged
Saptune details view #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
saptune-details-view
branch
2 times, most recently
from
0f5b7bc
to
4493b6f
Compare
EMaksy
force-pushed
the
saptune-details-view
branch
7 times, most recently
from
0af552c
to
fa43bac
Compare
arbulu89
commented
Sep 27, 2023
EMaksy
force-pushed
the
saptune-details-view
branch
5 times, most recently
from
0585125
to
1f3cdd0
Compare
arbulu89
commented
Sep 28, 2023
|
Also one minor thing i will update the existing tests |
EMaksy
force-pushed
the
saptune-details-view
branch
3 times, most recently
from
5bd0f0b
to
2511519
Compare
EMaksy
force-pushed
the
saptune-details-view
branch
2 times, most recently
from
6aef97f
to
548172a
Compare
EMaksy
force-pushed
the
saptune-details-view
branch
2 times, most recently
from
4f66516
to
4375dfa
Compare
EMaksy
reviewed
Sep 29, 2023
EMaksy
force-pushed
the
saptune-details-view
branch
from
4ff7a07
to
6e99a41
Compare
arbulu89
commented
Oct 2, 2023
| describe('SaptuneDetailsPage', () => { | ||
| it('should render not found when the host is missing', () => { | ||
| const hosts = hostFactory.buildList(2); | ||
| const hostID = 'NonExistingUUID'; |
There was a problem hiding this comment.
We should use faker.string.uuid(). The uuid will be unique
arbulu89
force-pushed
the
saptune-details-view
branch
from
6ac10c3
to
ffa83b5
Compare
arbulu89
force-pushed
the
saptune-details-view
branch
from
5c7ce33
to
49ef3e8
Compare
arbulu89
force-pushed
the
saptune-details-view
branch
from
49ef3e8
to
f029f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the saptune details view.
Preview
Disclaimer
The pr is already big enough, we decided to move the status icons for Saptune Service Status in a follow up pr.
How was this tested?
Automated Tests.