ASCS/ERS checks #2003
Merged
ASCS/ERS checks #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cibLastWritten, | ||
| provider, | ||
| hosts, | ||
| sapSystems, | ||
| details, | ||
| catalog, | ||
| lastExecution, | ||
| onStartExecution, |
There was a problem hiding this comment.
Should we provide a default noop function to onStartExecution and navigate?
onStartExecution = () => {},
navigate = () => {},We do that in the HanaClusterDetails component (which does not mean that is the best way, tho 😄 )
What's the way we prefer?
nelsonkopliku
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Super! I love when things click quite seamlessly! 🚀
Just some notes:
- there is a bit of duplication between
HanaClusterDetails,AscsErsClusterDetailsandHostDetailswhen it comes to the check related action buttons and the logic they carry. Let's just be aware and ready to tackle that. - we need to also send ensa version to the catalog api call when talking about ascs/ers cluster (at least in the checks selection). A followup PR would be totally ok.
- the catalog api call needs to start using the v2 exposed by wanda. I will take care of this as part of the work related to the catalog I am addressing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling checks selection and execution for ASCS/ERS clusters
How was this tested?
Unit tests added, additional stories not needed