Add a test suma connection endpoint #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
force-pushed
the
test-suma-connection-endpoint
branch
from
15b5348
to
9c49b2d
Compare
nelsonkopliku
changed the title
setup as a Discovery callback
nelsonkopliku
added
enhancement
jamie-suse
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an endpoint where connection against suma can be tested.
It either returns 200 or 422. If no settings were previously saved, 422 is returned.
No specific information about why the test failed is provided.
Added a 1s timeout for suma to login which in the worst case scenario where the last of the 5 attempts is successful would take around 5 seconds.
The other requests have a timeout of 5s by default.
A 10s timeout has been set to the genserver's calls, so that it covers for network timeouts and does not raise, but returns an error.
How was this tested?
Automated tests.