Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suma connection UI #2453

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Test suma connection UI #2453

merged 6 commits into from
Mar 22, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Mar 21, 2024

Description

This PR adds the ability to test the connection with the software updates provider: SUMA.
Uses endpoint implemented in #2444

Test connection button is enabled only if there are settings saved and if there is no test currently in progress.

Notifications are shown in both success or failure cases.

https://2453.prenv.trento.suse.com/

How was this tested?

Automated tests.

@nelsonkopliku nelsonkopliku self-assigned this Mar 21, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story ux javascript Pull requests that update Javascript code labels Mar 21, 2024
@nelsonkopliku nelsonkopliku changed the title Test suma connection btn Test suma connection UI Mar 21, 2024
@nelsonkopliku nelsonkopliku added the env Create an ephimeral environment for the pr branch label Mar 21, 2024
@nelsonkopliku nelsonkopliku force-pushed the test-suma-connection-btn branch 2 times, most recently from d3bf928 to d608309 Compare March 21, 2024 11:57
@nelsonkopliku nelsonkopliku marked this pull request as ready for review March 21, 2024 13:03
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple changes to apply then we can merge 👍

assets/js/pages/SettingsPage/SettingsPage.jsx Outdated Show resolved Hide resolved
assets/js/pages/SettingsPage/SettingsPage.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jamie-suse jamie-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit 65b1137 into main Mar 22, 2024
24 checks passed
@nelsonkopliku nelsonkopliku deleted the test-suma-connection-btn branch March 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request env Create an ephimeral environment for the pr branch javascript Pull requests that update Javascript code user story ux
Development

Successfully merging this pull request may close these issues.

None yet

3 participants