Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SUMA related controllers return 403 when credentials were not set #2602

Merged
merged 1 commit into from
May 7, 2024

Conversation

nelsonkopliku
Copy link
Member

Description

Following up an offline discussion about avoiding returning 401 for non trento related auth.

How was this tested?

Tests updated.

@nelsonkopliku nelsonkopliku force-pushed the suma-creds-api-proper-status-code branch from faeacbb to b79ea6a Compare May 7, 2024 12:24
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit ec85f73 into main May 7, 2024
26 checks passed
@nelsonkopliku nelsonkopliku deleted the suma-creds-api-proper-status-code branch May 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants