Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SUMA settings error handling #2610

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix SUMA settings error handling #2610

merged 1 commit into from
May 8, 2024

Conversation

nelsonkopliku
Copy link
Member

Description

Whoopsie, leftover from #2602 馃檲

@nelsonkopliku nelsonkopliku self-assigned this May 8, 2024
@nelsonkopliku nelsonkopliku added the bug Something isn't working label May 8, 2024
@nelsonkopliku nelsonkopliku added the env Create an ephimeral environment for the pr branch label May 8, 2024
dottorblaster
dottorblaster approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit 9cac935 into main May 8, 2024
51 checks passed
@nelsonkopliku nelsonkopliku deleted the fix-suma-settings-ui branch May 8, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@jamie-suse jamie-suse jamie-suse approved these changes

Assignees

@nelsonkopliku nelsonkopliku

Labels
bug Something isn't working env Create an ephimeral environment for the pr branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nelsonkopliku @dottorblaster @jamie-suse