open/upgrade methods
#12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
upgrade
branch
10 times, most recently
from
bcf9191
to
b106e36
Compare
|
Hi... I'm feeling pretty good now about the PR, having added more protection from impartial upgrades and tests. If you decide to accept my |
brettz9
force-pushed
the
upgrade
branch
5 times, most recently
from
6f7459d
to
ae97b5a
Compare
brettz9
changed the title
version() returns highest version r…open/upgrade methods
brettz9
force-pushed
the
upgrade
branch
10 times, most recently
from
4009892
to
a28854c
Compare
…allow a sequence of upgrades which can support promises returned by `addCallback` callbacks (and add docs and tests for multiple promise-based callbacks on different versions); Commenting: Indicate specific Safari bug within code; Refactoring: Use ES6 `Array.from`; add `Number.isInteger` and ES7 `Object.values()` in place of npm modules (requires babel-polyfill); Testing: Split off local testing from Sauce; prevent blocking; increase timeout for Firefox; add test to throw with previous version
|
Just a friendly reminder if you may have a chance to review... |
|
thank you @brettz9 for reminder, there're a lot of code to check, and you should be sure, that I remember about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Add
openandupgrademethods to allow a sequence of upgrades which can support promises returned byaddCallbackcallbacks (and add tests for multiple promise-based callbacks on different versions);Comment: Indicate specific Safari bug within code;
Refactoring: Use ES6
Number.isIntegerand ES7Object.values()in place of npm modules;Testing: Split off local testing from Sauce