Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change request] Launch Windows command console only when requested #79

Closed
trevorsandy opened this issue Sep 5, 2018 · 1 comment
Closed
Assignees
Milestone

Comments

@trevorsandy
Copy link
Owner

Subject

Currently a command console is launched automatically when launching LPub3D with one or more command flags from the Start/Run dialogue in Windows. There is a flag to suppress the command console but it is only available for batch mode.

This request is to flip the logic to launch the command console if requested versus suppress the console when requested.

Environment

  • Version of LPub3D - v2.3.0
  • Operating system - Windows x86, x86_64

Steps to reproduce

From the Start/Run dialogue, type "\LPub3D.exe" ""

Actual behaviour

Command console is launched when LPub3D is opened from a command line.

Workaround

While technically not a workaround, when you launch LPub3D without any flags, no command console is created.

Solution suggestion

Flip the logic to launch the command console if requested versus suppress the console when requested.

@trevorsandy trevorsandy self-assigned this Sep 5, 2018
@trevorsandy trevorsandy added this to the v2.3.1 milestone Sep 5, 2018
@trevorsandy trevorsandy added this to IN PROGRESS in LPub3D Maintenance Sep 6, 2018
@trevorsandy
Copy link
Owner Author

trevorsandy commented Sep 9, 2018

Completed.

On Windows platforms, the console windows will not be automatically created when LPub3D is launched from the Search/Run dialogue or a command console.

Starting with v2.3.1, a command line flag has been added to launch, connect to a command console:

-cr, --console-redirect: Create (or use existing) command console to redirect standard output standard error and standard input. Default is off.

screenshot - 09_09_2018 20_32_06

screenshot - 09_09_2018 20_32_27

Cheers,

LPub3D Maintenance automation moved this from IN PROGRESS to DONE Sep 9, 2018
@trevorsandy trevorsandy moved this from DONE to DEPLOYED in LPub3D Maintenance Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
LPub3D Maintenance
  
DEPLOYED
Development

No branches or pull requests

1 participant